DATACMNS-1833 - Revise documentation for query method keywords. #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buzzardo
suggested changes
Nov 20, 2020
mp911de
added a commit
that referenced
this pull request
Dec 1, 2020
Reformat asciidoc. Original pull request: #477.
mp911de
added a commit
that referenced
this pull request
Dec 1, 2020
Reformat asciidoc. Original pull request: #477.
mp911de
added a commit
that referenced
this pull request
Dec 1, 2020
Reformat asciidoc. Original pull request: #477.
mjustin
reviewed
Dec 1, 2020
| |=============== | ||
| |Keyword | Description | ||
| |`find…By`, `read…By`, `get…By`, `query…By`, `search…By`, `stream…By`| General query method returning typically the repository type, a `Collection` or `Streamable` subtype or a result wrapper such as `Page`, `GeoResults` or any other store-specific result wrapper. | ||
| |`exists…By`| Exists projection, returnung typically a `boolean` result. |
There was a problem hiding this comment.
Typo: "Returning" misspelled as "returnung" both here and in the next line.
There was a problem hiding this comment.
Good catch. That's fixed in the merge commits.
mjustin
reviewed
Dec 1, 2020
| @@ -27,7 +31,7 @@ NOTE: Geospatial types (such as `GeoResult`, `GeoResults`, and `GeoPage`) are av | |||
| |`Future<T>`|A `Future`. Expects a method to be annotated with `@Async` and requires Spring's asynchronous method execution capability to be enabled. | |||
| |`CompletableFuture<T>`|A Java 8 `CompletableFuture`. Expects a method to be annotated with `@Async` and requires Spring's asynchronous method execution capability to be enabled. | |||
| |`ListenableFuture`|A `org.springframework.util.concurrent.ListenableFuture`. Expects a method to be annotated with `@Async` and requires Spring's asynchronous method execution capability to be enabled. | |||
There was a problem hiding this comment.
Looks like this one should be generic as well: ListenableFuture<T>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: DATACMNS-1833.